Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make folder download less dangerous. #11

Open
axlbonnet opened this issue Jan 8, 2021 · 0 comments
Open

Make folder download less dangerous. #11

axlbonnet opened this issue Jan 8, 2021 · 0 comments

Comments

@axlbonnet
Copy link
Contributor

Currently the download folder operation take a local directory as parameter to store the zipped folder.

But this in not the directory in which the zip will be put as could be expected, but a local temp directory to create the zip content, that will be eventually deleted.
So clients MUST NOT give a existing folder for this result parameter because grida will delete it.

Either :

  • modify this method behavior (and all the places where it is used, with special attention in existing workflows)
  • deprecate the current method and create a new one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant