Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tileset options of Tile3DLayer are not passed to Tileset3D #9276

Open
7 tasks
sraimund opened this issue Dec 5, 2024 · 0 comments
Open
7 tasks

[Bug] Tileset options of Tile3DLayer are not passed to Tileset3D #9276

sraimund opened this issue Dec 5, 2024 · 0 comments
Labels

Comments

@sraimund
Copy link

sraimund commented Dec 5, 2024

Description

According to the Tile3DLayer docs, options for Tileset3D can be set like this:

const layer = new Tile3DLayer({
  ...
  loadOptions: {
    tileset: {
      throttleRequests: false,
    },
    ...
  }
})

However, those are not assigned in Tileset3D:

constructor(tileset: TilesetJSON, options?: Tileset3DProps) {
  ...
  this.loadOptions = this.options.loadOptions || {};
  ...
  this._requestScheduler = new RequestScheduler({
    throttleRequests: this.options.throttleRequests,
    maxRequests: this.options.maxRequests
  });
  ...
}

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CartoLayer
  • ArcGIS

Expected Behavior

The tileset options may be passed directly to Tileset3D in tile-layer-3d.ts:

private async _loadTileset(tilesetUrl) {
  ...
  const options = {loadOptions: {...loadOptions}};
  ...
  const tileset3d = new Tileset3D(tilesetJson, {
    onTileLoad: this._onTileLoad.bind(this),
    onTileUnload: this._onTileUnload.bind(this),
    onTileError: this.props.onTileError,
    ...options,
    ...options.loadOptions.tileset // added
  });
  ...
}

Steps to Reproduce

Specifying tileset options like throttleRequests, maxRequests, maximumMemoryUsage, etc. in Tile3DLayer has no effect.

Environment

  • Framework version: 9.0.36

Logs

No response

@sraimund sraimund added the bug label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant