fix(browser): restrict served files from /__screenshot-error
#7340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
approved these changes
Jan 23, 2025
|
Do we need to backport this to v2.0 and v2.1, by the way? |
|
Probably it's worth backporting. I'll do it in v2 branch, so it'll be included in v2.1.9. |
hi-ogawa
added a commit
to hi-ogawa/vitest
that referenced
this pull request
Jan 23, 2025
6 tasks
sheremet-va
pushed a commit
that referenced
this pull request
Jan 23, 2025
…creenshot-error` (#7343)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Jan 23, 2025
##### [v3.0.4](https://github.com/vitest-dev/vitest/releases/tag/v3.0.4) ##### 🐞 Bug Fixes - Filter projects eagerly during config resolution - by [@sheremet-va](https://github.com/sheremet-va) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7313 [<samp>(dff44)</samp>](vitest-dev/vitest@dff4406d) - Apply `development - by @hi-ogawa and @sheremet-va [<samp>(produ)</samp>](https://github.com/vitest-dev/vitest/commit/production` condition on Vite 6 ([#7301](vitest-dev/vitest#7301))) - **browser**: Restrict served files from `/__screenshot-error` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7340 [<samp>(ed9ae)</samp>](vitest-dev/vitest@ed9aeba2) - **deps**: Update all non-major dependencies - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7297 [<samp>(38ea8)</samp>](vitest-dev/vitest@38ea8eae) - **runner**: Timeout long sync hook - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7289 [<samp>(c60ee)</samp>](vitest-dev/vitest@c60ee27c) - **typechecking**: Support typechecking parsing with Vite 6 - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7335 [<samp>(bff70)</samp>](vitest-dev/vitest@bff70be9) - **types**: Fix public types - by [@mrginglymus](https://github.com/mrginglymus) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7328 [<samp>(ce6af)</samp>](vitest-dev/vitest@ce6af70c) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.3...v3.0.4)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Jan 24, 2025
##### [v3.0.4](https://github.com/vitest-dev/vitest/releases/tag/v3.0.4) ##### 🐞 Bug Fixes - Filter projects eagerly during config resolution - by [@sheremet-va](https://github.com/sheremet-va) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7313 [<samp>(dff44)</samp>](vitest-dev/vitest@dff4406d) - Apply `development - by @hi-ogawa and @sheremet-va [<samp>(produ)</samp>](https://github.com/vitest-dev/vitest/commit/production` condition on Vite 6 ([#7301](vitest-dev/vitest#7301))) - **browser**: Restrict served files from `/__screenshot-error` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7340 [<samp>(ed9ae)</samp>](vitest-dev/vitest@ed9aeba2) - **deps**: Update all non-major dependencies - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7297 [<samp>(38ea8)</samp>](vitest-dev/vitest@38ea8eae) - **runner**: Timeout long sync hook - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7289 [<samp>(c60ee)</samp>](vitest-dev/vitest@c60ee27c) - **typechecking**: Support typechecking parsing with Vite 6 - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7335 [<samp>(bff70)</samp>](vitest-dev/vitest@bff70be9) - **types**: Fix public types - by [@mrginglymus](https://github.com/mrginglymus) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7328 [<samp>(ce6af)</samp>](vitest-dev/vitest@ce6af70c) ##### [View changes on GitHub](vitest-dev/vitest@v3.0.3...v3.0.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I manually tested since we don't have a way to test browser mode UI yet.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.