Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events tab data grid performance improvement #7223

Open
asteriscos opened this issue Jan 8, 2025 · 1 comment · May be fixed by #7226
Open

Events tab data grid performance improvement #7223

asteriscos opened this issue Jan 8, 2025 · 1 comment · May be fixed by #7226
Assignees
Labels
level/task Task issue type/enhancement Enhancement issue

Comments

@asteriscos
Copy link
Member

asteriscos commented Jan 8, 2025

Wazuh Rev Browser
4.9.2 - Chrome

Description
The Events tab has a slow loading time, especially in heavily populated environments. We need to optimize the loading time of this view.

Screenshots
Image

Additional context
The data grid component seems to be involved in this performance issue.

@asteriscos asteriscos added type/enhancement Enhancement issue level/task Task issue labels Jan 8, 2025
@Desvelao
Copy link
Member

Desvelao commented Jan 9, 2025

Research

According to a research ( edr 4220 ) seems the Columns button could be the responsible of high loading times.

Currently the Column button manages the visibility and sorting of the table columns. We could not find any solution
that mitigates the problem using the Column button. But, reducing the count of fields managed by that button, according to the research of @asteriscos, seems to reduce the loading time.

Remediation

So, a possible approach is only using the Column button to sort the visible fields, and move the management of field visibility to another button that is added to the table like an additional control of the EuiDataGrid component.

POC

Copied from edr 4220 comment

This is based on the idea of removing the columns that receive the EuiDataGrid component because it seems to enhance the performance of the page according to the research of @asteriscos. To do this, we can move the ability to add/remove the visibility of fields to another additional control and the built-in Column button only manages the sort of visible columns.

  • Columns button: only manages the sort of columns

Built-in button with the ability to enable visibility disabled

  • Available fields: add/remove fields from columns
Screenshots

Image
Image

Patch applicable in the current 4.10.1 branch:
patch

Note: other sections are using the EuiDataGrid and could need to apply this additional control

Comparation:

Context:

  • around 56000 alerts
Test Time last request
No fix 4s
With patch 0.7s

@Desvelao Desvelao linked a pull request Jan 9, 2025 that will close this issue
4 tasks
@Desvelao Desvelao linked a pull request Jan 9, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants