Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Uploader breaks when Upload fails #36

Closed
kraftner opened this issue Oct 25, 2016 · 3 comments
Closed

Multi Uploader breaks when Upload fails #36

kraftner opened this issue Oct 25, 2016 · 3 comments
Assignees
@kraftner
Labels
bug
Milestone
1.0.0

Comments

@kraftner
Copy link
Member

To reproduce just try uploading an SVG file.

At first glance it seems as if the response from async-upload.php is assumed to always be an image, while this can also be an error message if the upload fails. This is then put in the template where the <img> is expected breaking the template somehow.
@kraftner kraftner added this to the 1.0.0 milestone Oct 25, 2016
@franz-josef-kaiser
Copy link
Member

@kraftner can you please update your issue with a link to the place in code where this is assumed?

@kraftner
Copy link
Member Author

Somewhere in here 😉
Haven't wrapped my head around the JS part yet.

@kraftner kraftner mentioned this issue Nov 4, 2016
Merged
@kraftner
Copy link
Member Author

fixed by #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kraftner kraftner

Labels
bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@franz-josef-kaiser @kraftner