-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content model and 'what' to render for stylable <select>
elements
#10317
Comments
To be clear, #10310 was to discuss a specific subset of #9799. What ends up getting rendered is really a function of the I think an accessible |
This needs refinement after accessibility semantics/constraints are figured out: whatwg#10317
This needs refinement after accessibility semantics/constraints are figured out: whatwg#10317
This needs refinement after accessibility semantics/constraints are figured out: whatwg#10317
This needs refinement after accessibility semantics/constraints are figured out: whatwg#10317
My draft spec has a proposed updated content model here: #10548 The gist of the changes:
Decorative images:
|
Why would we only allow decorative images? I think we should make |
This needs refinement after accessibility semantics/constraints are figured out: whatwg#10317
we had discussed images with alternative text being allowed. i think that might just be a miss. We had talked about how it could be problematic if people used images without alternative text or visible text in the option - and how that'd be an issue. but i know there was also discussion about needing to potentially address your previous comment.
with your latest comment, are you implying it might be ok if image has alternative text, then such platforms could render the alt text instead of the image? if so that'd be great. i was worried that if a platform decided not to render the image, that the whole image, including alt text, would be dropped. |
Relatedly, I think having authoring conformance requirements depend on ARIA seems a bit sketchy? ARIA is supposed to be used as a means of interfacing with AT, and not affect semantics or document conformance. |
@scottaohara right, it's called "replacement text" for a reason. I don't see why we couldn't use that. |
@annevk excellent, seems we're on the same page then. again, i think that's a mistake in relaying what had been discussed. an option should absolutely be able to contain non-decorative images. The only requirement with graphics being that if they are the only content of an option, they must have alternative text. the mention of decorative images was supposed to be in regard to if the graphic was a direct child of a select element (used outside of an option), not if it was a child of an option. cc @josepharhar @domenic that's fair, and if not for the fact that |
Thanks for the discussion! So it sounds like I should keep the content model the way it is but also remove the requirement of having alt='' or aria-hidden=true, and then add another requirement for this:
Anything I'm missing? If not then I can go update the content model in the draft spec. |
I don't think we need a specific requirement for this. There are many elements in the spec which don't make very much sense if they're empty (e.g., only whitespace, or only a non-alt image, or only |
For the |
We have "palpable content", but it might not be correct for Right now https://html.spec.whatwg.org/#the-option-element has
I think the intent is to catch the mistake where the contents of Should alt text be included in the submitted value? That would be a normative change, but maybe it's not a web compat problem (since you can't easily use images in |
I feel like the only case where making alt text the submitted value make sense is if there is no other text in the option element and the option element also doesn't have the value attribute. Wouldn't it make more sense to put a value attribute on the option as well?
This sounds in favor of including the "if they are the only content of an option, they must have alternative text" requirement. Do you think we should have that requirement? |
i don't see the downside of calling this out. Even if just briefly and cross linking over to https://html.spec.whatwg.org/multipage/images.html#alt for the more detailed requirements for when an |
It seems cumbersome if you would otherwise not have to do that. Since we already have a custom iterator to determine the text content we might as well handle Additionally, we have environments where we need to display the pure text version and that pure text version should be roughly the same as what AT sees I think and not necessarily reflect the submitted value (which can be nonsensical as far as an end user is concerned). |
It sounds like you're in favor of including alt text in the submitted value. Is that correct?
So it sounds like if the image it outside of the option it must not have alt text, and if its inside the image it must have alt text. I'm going to add this to the spec.
For svgs, can we just make aria-hidden get applied automatically as part of the accessibility mappings when needed? Also, how is alt text supposed to be put on svgs in order to follow the requirement that it must have alt text when used inside an option element? |
This needs refinement after accessibility semantics/constraints are figured out: whatwg#10317
just talked with @josepharhar about this, and per the feedback in this thread we are instead thinking to drop the explicit mention of decorative images from the content model entirely. Rather, author guidance can be provided in examples and notes, referencing back to existing spec content about the The only way I could still see graphics being mentioned in the content model, is in regard to needing a value to submit - so that an option like |
This PR updated the content model for the <select>, <option>, and <optgroup> elements in support of customizable <select>. Fixes whatwg#10317
This PR updated the content model for the <select>, <option>, and <optgroup> elements in support of customizable <select>. Fixes whatwg#10317
I was very surprised at the idea that Those accessibility strings are human-facing, whereas the submitted value is computer-facing. I worry that this will cause people to start writing their accessibility strings as computer-facing instead. |
I agree with domenic and I think that we can include I have a clarifying question though - should we use img alt text in the case that there is only an img with alt text and no other text in the option, or in all cases? If we're going to use img alt text in the case that there is also DOM text nodes, how should we concatenate the alt text with the adjacent DOM text nodes? Here's an example: <option>
<img alt="hello world" src=...>option one
</option> What should the label be? This would be easier if we only include alt text in the label when there is no DOM text nodes. @scottaohara |
all browsers handle this now per the accName algorithm. a space is added between the img element and the text in the calculation of the name. i think it would be a mistake to allow authors to use images in options, but throw a curve ball and tell them that setting an alt wouldn't do anything. it already works in the name calculation for the option, so this would effectively break something that already works fine. this seems more a problem with how to calculate the submitted value than what to expose to users visually / via the a11y tree. as far as that is concerned, i agree with Domenic that I would not expect ARIA to contribute to that at all. I would, however, expect an image's alt to be included as part of the text idl if an explicit if for some reason that's something that can't be solved, then it seems like there would need to be author guidance to state that if people are using images within their options, then they MUST also specify a value attribute with the string they want submitted. We're likely going to need that guidance to inform authors that ARIA should also not be expected to be considered for the submitted value of the option. Making a very clear distinction between the value someone perceives from an option's visible label or a11y name VS what would be the computed value that participates in form submission. |
What do you think the |
I am aware of the value IDL. Yes. thanks.... in my experience devs use the specified value, OR they expect the value to be calculated by the text content of the option - which given Anne's prior response, I would have thought the image's fallback text could have been made to take part of thta text calculation - so then per the HTML spec:
a developer could expect whatever they set as the option's text / label (including alt text) as to then become the value to send to the server. working with developers who work with javascript frameworks and component libraries that have custom selects built with JS / ARIA - they similarly either grab the computed text of an option (which might then need to include image’s alts), or they use a custom attribute / data- attribute to provide a value - or they just have it all setup in their scripting and the actual value of an option isn't included in what's sent to the DOM. all that said - i'm more concerned with the human facing label/value. if there is some reason that alt text can't be considered part of this computation, then i'm not trying to say "this must be done". far from it actually. I'm saying that if this can't be done, then developers need to be made aware of that. but i'm against the idea of not including an image's alt in the computed name/label of an option - per joey's comment "This would be easier if we only include alt text in the label when there is no DOM text nodes". Doing that would make something like But this is already a solved problem where the accname is properly computed for that situation. let's not break that because there seems to be hesitation about including an image's alt in the submitted value. If that won’t be done, then devs need to be informed that they must also set a value for instances where an image that serves as more than decoration is used. That might be inconvenient in some cases but shouldn’t be a huge problem for a dev. |
For sure, the human-facing name/label should include those things. I just think that does not need to have any connection the developer-facing |
then we agree on the part that's the most important to what i'm concerned with. While I have my preference, as long as its clear in the spec what will / won't be used to calculate an option's value if a value attribute is not set, then that's all that really matters to me on that topic. |
Thanks for the discussion! It sounds like alt text should be included for everything but the value attribute, and that alt text should be concatenated with other text by adding spaces. I will make these changes to chromium and the spec PR. |
Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a
Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a
Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137091 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404536}
Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137091 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404536}
…s, a=testonly Automatic update from web-platform-tests Include <img> alt text in <option> labels Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137091 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404536} -- wpt-commits: 061274f978d6b57e5e6bc4ee2cd7a882d886bb91 wpt-pr: 49973
Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137091 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404536}
…s, a=testonly Automatic update from web-platform-tests Include <img> alt text in <option> labels Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137091 Reviewed-by: David Baron <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1404536} -- wpt-commits: 061274f978d6b57e5e6bc4ee2cd7a882d886bb91 wpt-pr: 49973
…s, a=testonly Automatic update from web-platform-tests Include <img> alt text in <option> labels Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137091 Reviewed-by: David Baron <dbaronchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1404536} -- wpt-commits: 061274f978d6b57e5e6bc4ee2cd7a882d886bb91 wpt-pr: 49973 UltraBlame original commit: ae399208478ed46aed5d329251e91d83b9dc76dc
…s, a=testonly Automatic update from web-platform-tests Include <img> alt text in <option> labels Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137091 Reviewed-by: David Baron <dbaronchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1404536} -- wpt-commits: 061274f978d6b57e5e6bc4ee2cd7a882d886bb91 wpt-pr: 49973 UltraBlame original commit: ae399208478ed46aed5d329251e91d83b9dc76dc
…s, a=testonly Automatic update from web-platform-tests Include <img> alt text in <option> labels Discussion: whatwg/html#10317 Change-Id: Ie6ed230eb75d3ec24c51c76d587a11dde3d44b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6137091 Reviewed-by: David Baron <dbaronchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1404536} -- wpt-commits: 061274f978d6b57e5e6bc4ee2cd7a882d886bb91 wpt-pr: 49973 UltraBlame original commit: ae399208478ed46aed5d329251e91d83b9dc76dc
Today an It also seems inconsistent that |
No, that goes directly against what I suggested above. Again, I think the accessibility string should include the image alt text, but this should not be exposed anywhere besides to accessibility tech. It should not show up in This is the same as how even though alt text impacts accessibility, it does not show up in |
I don't really understand why you'd want web developers to write |
The following are the kinds of cases I'm concerned about <option>
<img alt="A fjord">Norway
</option>
<option>
<img alt="A Norweigan flag">
</option>
<!-- maybe in a game where you're selecting which country's army to send in -->
<option>
<img alt="A viking warrior, representing Norway">
</option> I don't think these are suitable values to submit to the server. The web developer should instead write specific I worry that your proposal would steer developers toward doing |
I don't see how those are materially different from I don't like making the model of The image forming a part of the contents (and thus influencing both "label" and "value" (and text I guess)) is also what @scottaohara argued for above, but getting more input from @whatwg/a11y on the tradeoff would probably be good. |
The difference is that today, people know that images never form part of text in DOM APIs, like
What is more complex? The model I'm arguing for is the model we use for option elements today: use the text content. You're the one arguing for adding an unprecedented step that starts treating alt attributes as text content. |
Today |
I was asked to weigh in on this thread, and after reading it all I have to say I'm pretty happy with the model we've arrived on in #10317 (comment), #10317 (comment), and #10317 (comment). It seems like myself, @scottaohara, @domenic, and @josepharhar are all satisfied with this direction of not including I'd love to hear from more people too, but I feel like we're just inches away from being able to resolve this issue in that direction. |
From an a11y perspective, I'm also supportive of the direction of not including image alt-text in the computed value property. I do agree that alt-text should (continue to) be used for accessible name/description computation, and display to the user when appropriate. However, adding this new behavior (unprecedented as well AIUI) of copying alt-text into server-submitted, and JS-visible values might have a detrimental effect on accessibility in general. Developers might find "odd" values in their value property, track them down to alt-text on contained images, and remove the alt-text to fix it. Perhaps they might even learn the lesson that alt-text breaks things, and stop using it elsewhere :(
+1 |
This is a follow on to #10310 to move discussion on what to do about the potential content models for styleable selects, and its current/proposed directly supported children/descendants (option, optgroup, hr, button, datalist). Additionally, I'd expect this discussion could also cover what may be rendered in a select or not, regardless of whether the elements are parsed out or not. (as was noted in the other issue, one can get around the parser and inject elements into a select - but they don't actually render. that's clearly not the intent for what changing the parser would do, continue to not have elements render - but maybe some still shouldnt?)
One reason to start this discussion is to also determine potential use cases / author intent for content that extends beyond the current content model. For instance, someone wanted to provide a description to an option element - they might think to intervene options with divs or paragraph elements to do this:
but that isn't really enough to just allow the paragraph in there - there needs to be an association between the paragraph and the option so that the paragraph's content can be relayed via the a11y api as the options description. And putting the paragraph within the option means it'd contribute to its accessible name (undesired).
So, is it enough to just allow any content in and have authors hook it up themselves. Or have HTML determine new definitions for how elements work together in this context? Or is it really a new supporting element that is needed, and allowing
main
,article
,video
,iframe
into the mix is just noise and potential for author error that didn't exist since the parser didn't allow these things before?I hope this serves as enough to get this ball rolling.
The text was updated successfully, but these errors were encountered: