Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GraphQL 4.5.0 #9

Open
sergeyovchinnikov opened this issue May 7, 2021 · 2 comments
Open

Upgrade to GraphQL 4.5.0 #9

sergeyovchinnikov opened this issue May 7, 2021 · 2 comments

Comments

@sergeyovchinnikov
Copy link

Hello,

would you please update the library to the GraphQL 4.5.0 code?

@kYann
Copy link
Contributor

kYann commented May 7, 2021

Hello !

I've tried a quick update and saw that GraphTypeRegistry has been removed (see here)

I've tried a quick fix but it does not work. Would you like to take the time to upgrade the library and submit a PR ?

Thanks,

@sergeyovchinnikov
Copy link
Author

Hello!,
i have forked a new branch, but, frankly, don't know how to handle it in a more elegant way because the built-in types are created in the schema itself now.
So, the info about the schema types should be created and registered in some container in a Schema ctor to decouple the
SchemaDeclare code from the application.
Anyway i will create a PR for an issue...

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants