Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issues on a clean install #441

Open
larsgw opened this issue May 24, 2020 · 7 comments
Open

Build issues on a clean install #441

larsgw opened this issue May 24, 2020 · 7 comments
Assignees

Comments

@larsgw
Copy link

larsgw commented May 24, 2020

The build:css script runs tcm src, but tcm is not installed on my system (and the Debian package with that name is not related to CSS). What is TCM and how can I use it?

@larsgw
Copy link
Author

larsgw commented May 24, 2020

Of course googling the exact same thing after opening the issue does lead to the result: typed-css-modules. Should that be added to the devDependencies?

@larsgw larsgw changed the title What's TCM? Build issues on a clean install May 24, 2020
@larsgw
Copy link
Author

larsgw commented May 24, 2020

  • typed-css-modules is not in devDependencies
  • sha1sum of a generated SVG does not matched due to floating point math
    diff --git a/test/expected/WP1243_69897.svg b/test/expected/WP1243_69897.svg
    index fbed87d9..a1a7722f 100644
    --- a/test/expected/WP1243_69897.svg
    +++ b/test/expected/WP1243_69897.svg
    @@ -2262,7 +2262,7 @@
               fill="transparent"
               fill-opacity="0"
               stroke="black"
    -          stroke-dasharray="186.09349673788157, 0"
    +          stroke-dasharray="186.09349673788145, 0"
               stroke-width="1"
             ><path
                 style="color:inherit;fill:inherit;fill-opacity:inherit;stroke:inherit;stroke-width:inherit"
    @@ -2273,7 +2273,7 @@
           ><g
               id="ccc0e"
               class="Burr Anchor"
    -          transform="translate(534.9243723785029,146.40897999475013)"
    +          transform="translate(534.9243723785029,146.4089799947501)"
             ><use
                 fill="#141414"
                 stroke-width="0"
    @@ -2289,7 +2289,7 @@
           ><g
               id="c2750"
               class="Burr Anchor"
    -          transform="translate(529.4884621414456,233.74091379440915)"
    +          transform="translate(529.4884621414456,233.74091379440912)"
             ><use
                 fill="#141414"
                 stroke-width="0"
  • prepare script has a typo && prepare:symlink-gpml2pvjson should be && npm run prepare:symlink-gpml2pvjson

@jacobwindsor
Copy link
Member

jacobwindsor commented Jun 3, 2020 via email

larsgw added a commit that referenced this issue Jun 7, 2020
@larsgw
Copy link
Author

larsgw commented Jun 7, 2020

@AlexanderPico
Copy link
Member

AlexanderPico commented May 12, 2023

New version coming soon. @larsgw Does this issue still require changes? Might want to include them soon for next npm release.

@larsgw
Copy link
Author

larsgw commented May 12, 2023

I have a pull request open which addresses the issues here, as well as updates some packages: #442. I don't know if those changes are out of date at this point though.

@larsgw
Copy link
Author

larsgw commented May 12, 2023

It does not address the tests failing due to floating point math changes (though I'm not sure why those differences appear in the first place, perhaps an updated dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants