Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify service registration and deployments #139

Open
hpehl opened this issue Aug 2, 2023 · 0 comments
Open

Clarify service registration and deployments #139

hpehl opened this issue Aug 2, 2023 · 0 comments
Labels
question Further information is requested
Milestone

Comments

@hpehl
Copy link
Collaborator

hpehl commented Aug 2, 2023

I think we need to consider how services are added. If multiple applications are deployed, only the first deployment started registers its services with the gRPC server. I'm not sure if there is some variant of a mutable server, but if not, it will take some thought on how this could be done. I don't think we want to stop and restart a server for every deployment being processed. It's experimental, but we might need something like this https://grpc.github.io/grpc-java/javadoc/io/grpc/util/MutableHandlerRegistry.html.

Another thing to consider along these lines is if there are any possible security issues around registering services from different deployments on the same gRPC server. Again, I'd need to read more here to understand how this works. However, we don't want to allow deploymentA to see services from deploymentB.

@hpehl hpehl added the question Further information is requested label Aug 2, 2023
@hpehl hpehl added this to the 0.2 milestone Aug 2, 2023
@darranl darranl modified the milestones: 0.1.4, 0.1.5 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants