Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out cURL 8.11.1 #25

Open
cmb69 opened this issue Nov 6, 2024 · 6 comments
Open

Roll out cURL 8.11.1 #25

cmb69 opened this issue Nov 6, 2024 · 6 comments

Comments

@cmb69
Copy link
Member

cmb69 commented Nov 6, 2024

cURL 8.11.0 has been released, fixing CVE-2024-9681. Given that is a low severity issue, it might not be necessary to update stable branches right away (should wait after GA at least). I've already pushed the update to master, and did quick testing as usual, and found that now Websocket support is enabled by default. Probably not a problem, since that seems to require special support in ext/curl; otherwise I'd be wary to roll it out to stable versions.

Note that nghttp2 1.64.0 is available to be built as prerequisite for the cURL update.

@nielsdos, any thoughts about the update?

@cmb69
Copy link
Member Author

cmb69 commented Nov 6, 2024

Ah forgot: if we roll 8.11.0 out with Websocket support, we need to apply the following patch to php-src:

 ext/curl/tests/check_win_config.phpt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ext/curl/tests/check_win_config.phpt b/ext/curl/tests/check_win_config.phpt
index b3beb044a7..8330a95564 100644
--- a/ext/curl/tests/check_win_config.phpt
+++ b/ext/curl/tests/check_win_config.phpt
@@ -54,7 +54,7 @@
 ZSTD => No
 HSTS => Yes
 GSASL => No
-Protocols => dict, file, ftp, ftps, gopher, %r(gophers, )?%rhttp, https, imap, imaps, ldap, ldaps, %r(mqtt, )?%rpop3, pop3s, rtsp, scp, sftp, smb, smbs, smtp, smtps, telnet, tftp
+Protocols => dict, file, ftp, ftps, gopher, %r(gophers, )?%rhttp, https, imap, imaps, ldap, ldaps, %r(mqtt, )?%rpop3, pop3s, rtsp, scp, sftp, smb, smbs, smtp, smtps, telnet, tftp%r(, ws, wss)?%r
 Host => %s-pc-win32
 SSL Version => OpenSSL/%s
 ZLib Version => %s

@nielsdos
Copy link
Contributor

nielsdos commented Nov 6, 2024

Let's wait until after GA and then make sure the next release uses the update.

Ah forgot: if we roll 8.11.0 out with Websocket support, we need to apply the following patch to php-src:

This likely needs to happen anyway for the Linux users who receive the update via their distro.

@cmb69
Copy link
Member Author

cmb69 commented Nov 6, 2024

Let's wait until after GA and then make sure the next release uses the update.

Fine. I'll keep an eye on it.

This likely needs to happen anyway for the Linux users who receive the update via their distro.

The test is Windows only. :)

@nielsdos
Copy link
Contributor

nielsdos commented Nov 6, 2024

Fine. I'll keep an eye on it.

Thanks!

The test is Windows only. :)

Ah oops, I missed that. EDIT: duh, it even says win in the title... 🤦

@cmb69
Copy link
Member Author

cmb69 commented Nov 8, 2024

I guess we want to wait for cURL 8.11.1: https://curl.se/mail/lib-2024-11/0019.html

@cmb69
Copy link
Member Author

cmb69 commented Dec 11, 2024

I've pushed cURL 8.11.1 (which fixes another low severity vulnerability) to master. Test build showed no further issues.

I suggest to wait with rolling out until PHP GA's have been released (scheduled for Dec 19th), and then first push staging to stable (we're behind with this for a couple of months). Afterwards we can roll out new releases.

@cmb69 cmb69 changed the title Roll out cULR 8.11.0 Roll out cULR 8.11.~~0~~<ins>1</ins> Dec 11, 2024
@cmb69 cmb69 changed the title Roll out cULR 8.11.~~0~~<ins>1</ins> Roll out cULR 8.11.1 Dec 11, 2024
@cmb69 cmb69 changed the title Roll out cULR 8.11.1 Roll out cURL 8.11.1 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants