Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md is not updated for usage example #33

Open
jtara1 opened this issue Nov 14, 2018 · 2 comments
Open

README.md is not updated for usage example #33

jtara1 opened this issue Nov 14, 2018 · 2 comments

Comments

@jtara1
Copy link

jtara1 commented Nov 14, 2018

using:
[email protected]
node v8.11.1

should be

const winston = require('winston');
const Redis = require('winston-redis');
winston.add(new Redis);

in the file in which you create your winston logger

@jtara1
Copy link
Author

jtara1 commented Nov 14, 2018

My creation of a winston logger and usage of this module is actually causing the process to not exit. Not sure if that's a different issue or I'm still misunderstanding the basic usage for setup.

@mgibeau
Copy link
Member

mgibeau commented Nov 18, 2018

Thanks for the report, I've adjusted the documentation. Regarding the open process, have you tried calling logger.close()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants