Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Allow params for entries request #89

Open
edison opened this issue Jan 20, 2019 · 0 comments
Open

Allow params for entries request #89

edison opened this issue Jan 20, 2019 · 0 comments

Comments

@edison
Copy link
Contributor

edison commented Jan 20, 2019

Just allow to use LIMIT and OFFSET parameters for entries request as described on API docs: https://dev.wirecard.com.br/v2.0/reference#listar-todos-lan%C3%A7amentos

Without this it's impossible to get more than 20 entries through this SDK.

I had previously made a pull-request (#86) to fix this, but I couldn't reopen. So I'm giving the following code which works properly if you can make the change directly:

File: lib/moip2/entry_api.rb

You need to change the find_all method to the following:

def find_all(params = {})
  params = URI.encode_www_form params
  Resource::Entry.new client, client.get("#{base_path}?#{params}")
end
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant