Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View form taster #1

Open
ainulrafiq opened this issue Nov 30, 2020 · 11 comments
Open

View form taster #1

ainulrafiq opened this issue Nov 30, 2020 · 11 comments

Comments

@ainulrafiq
Copy link

ainulrafiq commented Nov 30, 2020

Dear Withanage, we have tasted the plugin, and here is the result https://myjurnal.poltekkes-kdi.ac.id/index.php/HIJP/article/view/204/version/119 for the affiliation has in the ROR database, and, here https://myjurnal.poltekkes-kdi.ac.id/index.php/HIJP/article/view/200 that the affiliation not in the ROR database.

Thank you!

@withanage
Copy link
Owner

withanage commented Nov 30, 2020

@ainulrafiq

Thanks a lot for the quick testing.
the plugin variable is not yet in the template , you have to patch the ojs 3.2.1
article_details.tpl as here or update the branch , if you have the installation under git.
https://github.com/withanage/ror/

Then you will see the ror badge.

About 200, I will create a patch soon.

@ainulrafiq
Copy link
Author

@withanage
I've tried to patch the article.tpl use the extra code
{if $author->getData('rorId')}
{$rorIdIcon}
{/if}
and the ROR link still not transform into a badge .. :-)

@withanage
Copy link
Owner

@ainulrafiq 200 should be fixed with the latest commit now.

With Badge, we have to test may be together, cause actually I could not reproduce it.

Will you be able to have a very short online call ?

@ainulrafiq
Copy link
Author

ainulrafiq commented Nov 30, 2020 via email

@withanage
Copy link
Owner

withanage commented Dec 1, 2020

Dear @ainulrafiq
Thanks, I have written you an email and taken your email out of the comment for privacy.

@withanage
Copy link
Owner

Dear @ainulrafiq
could you test this version ?
https://github.com/withanage/ror/releases/tag/v1_0_0-1

@ainulrafiq
Copy link
Author

ainulrafiq commented Dec 3, 2020

Dear @withanage , I just try out the new one above and the ROR badge appears. https://myjurnal.poltekkes-kdi.ac.id/index.php/HIJP/article/view/204

but, there is color changes on the ORCID iD badge ..

@withanage
Copy link
Owner

withanage commented Dec 3, 2020

Dear @ainulrafiq
thanks, this patch should fix that.
https://github.com/withanage/ror/releases/tag/v1_0_0-5
Please delete template cache too.

@ainulrafiq
Copy link
Author

Dear @withanage , I have applied the patch you mentioned above but there are no chances for the ORCID iD badge's color .. thanks

@withanage
Copy link
Owner

withanage commented Dec 4, 2020

Dear @ainulrafiq ,

That was a very good one, you found. Thanks !

could you plelase try this version ?

https://github.com/withanage/ror/releases/tag/v1_0_0-6

You may have to delete the template cache and also the cache in your browser.

@ainulrafiq
Copy link
Author

Dear @withanage , I pleased to inform you that the last version does not change the ORCID iD badge color.
https://myjurnal.poltekkes-kdi.ac.id/index.php/HIJP/article/view/204

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants