Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpimath] Implement Translation3d.RotateAround #7661

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[wpimath] Implement Translation3d.RotateAround #7661

wants to merge 4 commits into from
+94 −1

Conversation

HarryXChen3
Copy link
Contributor

Closes #7658

@HarryXChen3 HarryXChen3 requested a review from a team as a code owner January 8, 2025 19:50
@github-actions github-actions bot added the component: wpimath Math library label Jan 8, 2025
@HarryXChen3
Copy link
Contributor Author

Also added a test for Translation2d.RotateAround since I noticed it didn't seem to have one

@HarryXChen3 HarryXChen3 force-pushed the translation3d-rotatearound branch from a680e6a to feb82d5 Compare January 9, 2025 01:19
KangarooKoala
KangarooKoala approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, for what it's worth. You'll need approval from someone else who's actually on the wpilibsuite team.

@HarryXChen3
Copy link
Contributor Author

HarryXChen3 commented Jan 9, 2025 •
edited
Loading

Looks like tests failed on InterruptTest.RisingEdge, I assume that has nothing to do with my changes? Is it just a flaky test?

@Gold856
Copy link
Contributor

Gold856 commented Jan 9, 2025

Just a flaky test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala KangarooKoala approved these changes

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
component: wpimath Math library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement rotateAround() for Translation3d
4 participants
@HarryXChen3 @Gold856 @calcmogul @KangarooKoala