Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

„Powered by giphy“ missing #15

Open
off1ine opened this issue Apr 5, 2020 · 6 comments
Open

„Powered by giphy“ missing #15

off1ine opened this issue Apr 5, 2020 · 6 comments

Comments

@off1ine
Copy link

off1ine commented Apr 5, 2020

Hey there, I‘m missing the „powered by giphy“ label above the search results - can you give me a hint how to get it to show up? It‘s needed for the app verification by giphy.
Thanks a lot for your work!

@jacotec
Copy link

jacotec commented Oct 26, 2020

Is there any movement regarding this issue? I'm still having the same issue and I'm unable to convert the API key to a production one due to this issue.

@wreiske
Copy link
Owner

wreiske commented Oct 26, 2020

I'm not sure why you're not seeing it.

image

Are you using the latest version? @off1ine @jacotec

@jacotec
Copy link

jacotec commented Oct 26, 2020

@wreiske Ah, OK ... this one ;-)

I see this, yes ... it's different from the marketplace screenshots where the "powered by..." is right above the results. If this is OK for Giphy, I'll try to get a production key. Will report.

Thanks!

@FaserF
Copy link

FaserF commented Nov 19, 2020

Feedback: had some conversation with the GIPHY devs. They want that the GIPHY is written in Capslock. The command in lower case seems to be okay.
image

@tiuz1
Copy link

tiuz1 commented Jan 19, 2021

Just wanted to convert the API Key into production but this is what giphy replied:

Thanks for your interest in using our API. Per our terms of service, we require all users of our API to include the approved "Powered by GIPHY" attribution. It looks as though your attribution is currently in plain text, which is not compliant with our terms. You can download approved assets here: http://giphymedia.s3.amazonaws.com/giphy-attribution-marks.zip Once you make that fix, can you please edit your application and attach a video capture of the user experience for adding GIFs in your app?

@wreiske
Copy link
Owner

wreiske commented Jan 19, 2021

This is quickly becoming a Rocket.Chat issue. If the powered by needs to be an image, there may need to be a change to the app engine.

FWIW just leave the API key field blank and it will use a working API key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants