Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop Menu component(s) - replaces direct use of Blueprint #2400

Open
amcclain opened this issue Apr 14, 2021 · 2 comments
Open

Desktop Menu component(s) - replaces direct use of Blueprint #2400

amcclain opened this issue Apr 14, 2021 · 2 comments
Assignees

Comments

@amcclain
Copy link
Member

This is a weird gap that came up in our discussion on PR #1800.

We provide Hoist-level support for menus in a few places:

But we don't provide a first-class way to setup e.g. a button on a toolbar that shows a menu - you need to use BP kit components.

We should review and reconcile the existing approaches and come up with a first iteration (however minimal) of a Hoist menu package for desktop.

@lbwexler
Copy link
Member

lbwexler commented May 7, 2021

Raising the priority of this. The ContextMenu API was actually substantially changed in Blueprint 4.0, and this is actually the main blocker to upgrading to Blueprint 4.0.

The new api does not provide an obvious way to respond to the actual mouse event, and dynamically construct the menu at that time. Rather than invest more time and contortions into targeting the new blueprint context menu api we should just promote some verison of the mobile menu as a desktop (or cross-platform) native Hoist menu component.

@lbwexler lbwexler linked a pull request May 7, 2021 that will close this issue
6 tasks
@amcclain amcclain added this to the Medium Term milestone Jun 23, 2021
@amcclain
Copy link
Member Author

@amcclain amcclain removed the big label Apr 21, 2022
@amcclain amcclain modified the milestones: Medium Term, v49 Apr 21, 2022
@ghsolomon ghsolomon mentioned this issue Apr 27, 2022
6 tasks
@lbwexler lbwexler modified the milestones: v49, v50, v51 Jul 12, 2022
@saba-mo saba-mo removed this from the v51 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants