Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertion functions for skew failing #299

Closed
Rosie23 opened this issue Feb 23, 2024 · 1 comment · Fixed by #300
Closed

assertion functions for skew failing #299

Rosie23 opened this issue Feb 23, 2024 · 1 comment · Fixed by #300

Comments

@Rosie23
Copy link

Rosie23 commented Feb 23, 2024

Functions testNoSkew(), checkNoSkew(), assertNoSkew(), testNegativeSkew(), checkNegativeSkew(), testPositiveSkew(), checkPositiveSkew(), assertPositiveSkew() do not work correctly.

Function uses skewType(object$skewness()) == "No Skew" (uppercase) however skewType() returns skew in all lowercase returning a FALSE irrespective of skew.

Failing tests
expect_true(testNoSkew( Binomial$new()))
@RaphaelS1 RaphaelS1 mentioned this issue Feb 23, 2024
Merged
@RaphaelS1
Copy link
Collaborator

Thanks @Rosie23 - fixed here #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update assertions.R xoopR/distr6
2 participants
@Rosie23 @RaphaelS1