Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider both column annotation - current field and parent #117

Open
AndrewVorobey opened this issue Jan 15, 2025 · 2 comments
Open

Consider both column annotation - current field and parent #117

AndrewVorobey opened this issue Jan 15, 2025 · 2 comments

Comments

@AndrewVorobey
Copy link

According documentation of Column.name: Each column will have the "BIG_SUBOBJ_FLAT" prefix

But it doesn't work if child object has column annotation with specified name. In this case parent's Column.name is ignored.

@nvamelichev
Copy link
Collaborator

Unfortunately this is a backwards incompatible change. There are already subobjects with column names specifically set to work around this issue...

The fix should only be enabled if the subobject column name contains no "_" (standard column namr separator) and/or a feature flag is set.

@AndrewVorobey
Copy link
Author

The fix should only be enabled if the subobject column name contains no "_" (standard column namr separator).

It doesn't correct as well, because there are projects with properties named contains "_". And it would be too confusing to have different behavior based on variable name.

I could introduce a new flag useParentNameAsPrefix on annotation @Column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants