Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make yiisoft/assets dependency optional #199

Open
vjik opened this issue Jan 18, 2025 · 3 comments
Open

Make yiisoft/assets dependency optional #199

vjik opened this issue Jan 18, 2025 · 3 comments
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@vjik
Copy link
Member

vjik commented Jan 18, 2025

In project, bootstrap can be added in different ways and Yii Assets usage is one of them only. For example, user can get bootstrap by YARN and manually connect to project without Yii Assets usage. So we should make Yii Assets dependency optional.

@samdark
Copy link
Member

samdark commented Jan 18, 2025

True but that introduces some inconvenience i.e. "just composer install" won't work anymore, it will require some manual configuration.

@samdark
Copy link
Member

samdark commented Jan 18, 2025

@terabytesoftw what do you think?

@vjik
Copy link
Member Author

vjik commented Jan 18, 2025

True but that introduces some inconvenience i.e. "just composer install" won't work anymore, it will require some manual configuration.

It's already done: https://github.com/yiisoft/yii-bootstrap5?tab=readme-ov-file#install-assets

@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Development

No branches or pull requests

2 participants