Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid values slip through #160

Open
yozik04 opened this issue May 13, 2024 · 3 comments
Open

Invalid values slip through #160

yozik04 opened this issue May 13, 2024 · 3 comments

Comments

@yozik04
Copy link
Owner

yozik04 commented May 13, 2024

Unfortunately we have a regression that now invalid values slip into HomeAssistant:

NibeGw, register address 40016 (EB100-EP14-BT11 Brine Out Temp). Which is signed 16bit.
image

@yozik04
Copy link
Owner Author

yozik04 commented May 13, 2024

Hmm:

Int16sl.parse(b'\x00\x80')
-32768

Int16sl.parse(b'\x01\x80')
-32767

@yozik04
Copy link
Owner Author

yozik04 commented May 13, 2024

I see that at the same time other values were also read wrong.
image

I think we should add some checks and discard whole received packet if any of the values are not invalid. I have no idea how it manages to bypass checksum check. I see this happen from time to time. Noticed second time this week.

@elupus
Copy link
Collaborator

elupus commented May 13, 2024

Looks quite weird. I wonder how we could detect that case.

yozik04 added a commit that referenced this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants