-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't find all forks #9
Comments
While I can't comment for certain (as I don't have much experience with Ruby/Octokit) I have a pretty good idea of why this is. Typically, when using the Github REST API, sending a GET request to It is possible to get all of the forks - at least using traditional means such as curl, you simply send a GET request to Here's the issue: the github API limits you to 5,000 requests per hour (at least, for OAuth apps - it could be even fewer) and each "page" you request counts against this. The API doesn't state any way to simply request all pages . . . trying to get each of these pages individually would totally break functionality. Take this example: let's say a user requested all of the forks of The only option here is to ditch the REST API and use the v4 API - again, I don't really have any experience with it, so it may also limit API calls (though it's designed to be more flexible in the data requested, so I'd be surprised if you couldn't get all forks at once). Plus, I have no idea if Octokit supports using the v4 API so it might require a total overhaul of the code base. |
This is a great tool. However, does it actually list all forks? I went to: http://forked.yannick.io/dfabulich/choicescript
I noticed I am not in the list: https://github.com/Flurrywinde/choicescript
Also, recently I saw another fork made an update, but that fork was also not in this list: https://github.com/ldarren/choicescript/commits/master
The text was updated successfully, but these errors were encountered: