From cbfdabd1bb00ea43e111106c6dda6105bc078c71 Mon Sep 17 00:00:00 2001
From: Aneesh Makala <amakala@yugabyte.com>
Date: Fri, 13 Dec 2024 11:31:22 +0530
Subject: [PATCH] add to notes

---
 yb-voyager/cmd/assessMigrationCommand.go                 | 8 +++++++-
 yb-voyager/src/query/queryissue/parser_issue_detector.go | 8 ++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/yb-voyager/cmd/assessMigrationCommand.go b/yb-voyager/cmd/assessMigrationCommand.go
index 90fa21cff..49d739dd9 100644
--- a/yb-voyager/cmd/assessMigrationCommand.go
+++ b/yb-voyager/cmd/assessMigrationCommand.go
@@ -1330,7 +1330,8 @@ To manually modify the schema, please refer: <a class="highlight-link" href="htt
 
 	ORACLE_UNSUPPPORTED_PARTITIONING = `Reference and System Partitioned tables are created as normal tables, but are not considered for target cluster sizing recommendations.`
 
-	GIN_INDEXES = `There are some BITMAP indexes present in the schema that will get converted to GIN indexes, but GIN indexes are partially supported in YugabyteDB as mentioned in <a class="highlight-link" href="https://github.com/yugabyte/yugabyte-db/issues/7850">https://github.com/yugabyte/yugabyte-db/issues/7850</a> so take a look and modify them if not supported.`
+	GIN_INDEXES         = `There are some BITMAP indexes present in the schema that will get converted to GIN indexes, but GIN indexes are partially supported in YugabyteDB as mentioned in <a class="highlight-link" href="https://github.com/yugabyte/yugabyte-db/issues/7850">https://github.com/yugabyte/yugabyte-db/issues/7850</a> so take a look and modify them if not supported.`
+	UNLOGGED_TABLE_NOTE = `There are some Unlogged tables in the schema. They will be created as regular LOGGED tables in YugabyteDB as unlogged tables are not supported.`
 )
 
 const FOREIGN_TABLE_NOTE = `There are some Foreign tables in the schema, but during the export schema phase, exported schema does not include the SERVER and USER MAPPING objects. Therefore, you must manually create these objects before import schema. For more information on each of them, run analyze-schema. `
@@ -1357,7 +1358,12 @@ func addNotesToAssessmentReport() {
 				}
 			}
 		}
+	case POSTGRESQL:
+		if parserIssueDetector.IsUnloggedTablesIssueFiltered {
+			assessmentReport.Notes = append(assessmentReport.Notes, UNLOGGED_TABLE_NOTE)
+		}
 	}
+
 }
 
 func addMigrationCaveatsToAssessmentReport(unsupportedDataTypesForLiveMigration []utils.TableColumnsDataTypes, unsupportedDataTypesForLiveMigrationWithFForFB []utils.TableColumnsDataTypes) {
diff --git a/yb-voyager/src/query/queryissue/parser_issue_detector.go b/yb-voyager/src/query/queryissue/parser_issue_detector.go
index 27d28fa93..197f3b210 100644
--- a/yb-voyager/src/query/queryissue/parser_issue_detector.go
+++ b/yb-voyager/src/query/queryissue/parser_issue_detector.go
@@ -59,6 +59,10 @@ type ParserIssueDetector struct {
 
 	//Boolean to check if there are any Gin indexes
 	IsGinIndexPresentInSchema bool
+
+	// Boolean to check if there are any unlogged tables that were filtered
+	// out because they are fixed as per the target db version
+	IsUnloggedTablesIssueFiltered bool
 }
 
 func NewParserIssueDetector() *ParserIssueDetector {
@@ -114,6 +118,10 @@ func (p *ParserIssueDetector) getIssuesNotFixedInTargetDbVersion(issues []QueryI
 		}
 		if !fixed {
 			filteredIssues = append(filteredIssues, i)
+		} else {
+			if i.Issue.Type == UNLOGGED_TABLE {
+				p.IsUnloggedTablesIssueFiltered = true
+			}
 		}
 	}
 	return filteredIssues, nil