Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nikic/php-parser v5 (supports PHP 7.4 too) #1690

Closed
wouter90 opened this issue Jan 8, 2025 · 3 comments · Fixed by #1691
Closed

Support nikic/php-parser v5 (supports PHP 7.4 too) #1690

wouter90 opened this issue Jan 8, 2025 · 3 comments · Fixed by #1691

Comments

@wouter90
Copy link

wouter90 commented Jan 8, 2025

Would it be possible to support nikic/php-parser v5 next to v4?
@DerManoMann
Copy link
Collaborator

I suppose - funny, no idea why I didn't use v5 to start of 🦀

@wouter90
Copy link
Author

wouter90 commented Jan 8, 2025

I tried to update it but because vimeo/psalm still requires v4 it can't update to v5. v5 is WIP at vimeo/psalm#11035

@DerManoMann
Copy link
Collaborator

Yeah, I can see that - strange, I am missing the 'upgrade to phpstan2' commit... that did bump things a bit...

@DerManoMann DerManoMann mentioned this issue Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tooling and dependency versions DerManoMann/swagger-php
2 participants
@DerManoMann @wouter90