Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden tests to CI #335

Closed
TurtlePU opened this issue Nov 7, 2024 · 2 comments · Fixed by #437
Closed

Add golden tests to CI #335

TurtlePU opened this issue Nov 7, 2024 · 2 comments · Fixed by #437
Assignees

Comments

@TurtlePU
Copy link
Contributor

TurtlePU commented Nov 7, 2024

When anyone changes compiler-related code, the numbers in symbolic-examples:bench-compiler are bound to change.
Should we add the golden test run to CI to track changes?

@vlasin
Copy link
Contributor

vlasin commented Nov 8, 2024

Yes, let's add them!

@TurtlePU TurtlePU mentioned this issue Dec 15, 2024
6 tasks
@echatav
Copy link
Contributor

echatav commented Dec 18, 2024

Rather than golden tests, why not run symbolic-examples:bench-compiler in CI right after linting and before auto-committing? Then optimizations and regressions will show up in PRs and we can pull them from remote. It may be a little less to write and help shorten the dev cycle.

Edit: Now I think probably that's exactly what you mean!

@TurtlePU TurtlePU linked a pull request Jan 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants