Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update static assets #122

Open
lcjohnso opened this issue Apr 15, 2021 · 1 comment
Open

update static assets #122

lcjohnso opened this issue Apr 15, 2021 · 1 comment

Comments

@lcjohnso
Copy link
Member

Current behavior: The current app pulls static images (for logos, etc) via Wordpress upload URLs (e.g., https://chelseatroy.com/wp-content/uploads/2020/07/nasa-partner.png).

Desired behavior: Preference would be to add these images as static assets bundled with the app (e.g., in /static dir?), but also could move these to Zoo-hosted blob storage (e.g., https://static.zooniverse.org/assets/zooniverse-icon-web-black.png).

@camallen
Copy link
Contributor

fwiw any assets being served from the static.zooniverse.org domain should be scoped to the origin host domain to avoid a clasing dumping ground folder

e.g. instead of putting the zooniverse-icon-web-black.png file in the root folder of assets on that blob storage container, instead put them to the theia.zooniverse.org folder to ensure we don't have clashing assets cascading to other domains.
The resulting URL would look like https://static.zooniverse.org/theia.zoonivese.org/zooniverse-icon-web-black.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants