Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphqlsp): Fix wrong fileType diagnostic error when introspection is disabled #348

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

FyndetNeo
Copy link
Contributor

When using the unused field detection feature without utilising the introspection generation an error is added to the diagnostics.

This is because the code tries to save an introspection file even when the provided output path is undefined.

I have made this small fix to stop the plugin from trying to save an introspection file when the output path is undefined.

This is relevant to me, because in the Project i am working on we use other ways of generating typescript files but want to use the unused field detection and autocompletion. This works fine in the IDE, but when reading the diagnostics of typescript in the CLI to create a pipeline that ensures every field is used, we also get an error about an unsupported file type for the introspection output path (Thrown in saveTadaIntrospection).

I just want to add that we very much enjoy the features this package provides, so thank you for your work!
Have a great day!
Looking forward to your feedback,
Leo

Copy link

changeset-bot bot commented Aug 4, 2024

🦋 Changeset detected

Latest commit: e634c4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@0no-co/graphqlsp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changeset but the overall change looks good!

@JoviDeCroock JoviDeCroock merged commit d0b4301 into 0no-co:main Aug 12, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants