Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update instructions for execution last opcode only #1068

Merged
merged 3 commits into from
Sep 2, 2024
Merged

update instructions for execution last opcode only #1068

merged 3 commits into from
Sep 2, 2024

Conversation

kstoykov
Copy link
Collaborator

No description provided.

@kstoykov kstoykov linked an issue Aug 29, 2024 that may be closed by this pull request
Panic OOM During Large Create #1046
Closed
@cla-bot cla-bot bot added the cla-signed label Aug 29, 2024
hexoscott
hexoscott previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@hexoscott hexoscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat solution 👌

@kstoykov kstoykov marked this pull request as ready for review August 30, 2024 13:35
@kstoykov
Copy link
Collaborator Author

kstoykov commented Aug 30, 2024 •
edited
Loading

@mandrigin @hexoscott
This PR is fixing the OOM for sure. The modifications that this PR introduce have direct impart on witness generation. Tests that verify witness are currently running but it will take days before they are ready.

@hexoscott hexoscott enabled auto-merge (squash) August 30, 2024 15:14
@kstoykov kstoykov force-pushed the 1046-panic-oom-during-large-create branch from 8e95ade to 6ac7801 Compare September 2, 2024 07:47
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mandrigin
mandrigin approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@mandrigin mandrigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passed all tests from John.

@hexoscott hexoscott merged commit be2c547 into zkevm Sep 2, 2024
14 checks passed
@hexoscott hexoscott deleted the 1046-panic-oom-during-large-create branch September 2, 2024 08:09
Stefan-Ethernal pushed a commit that referenced this pull request Sep 20, 2024
@kstoykov @hexoscott @Stefan-Ethernal
update instructions for execution last opcode only (#1068)
b4052c7 
* update instructions for execution last opcode only

* copy jump table before executing last opcode

---------

Co-authored-by: hexoscott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandrigin mandrigin mandrigin approved these changes

@hexoscott hexoscott hexoscott left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic OOM During Large Create
3 participants
@kstoykov @mandrigin @hexoscott