Adding constRoot to the transcript and tags #51

RogerTaule · 2023-10-12T12:28:58Z

This PR adds the following changes:

ConstRoot is now added as part of the transcript.
Several comments has been added to the bn128 circuits, with specific attention to bn1togl3 circuit.
Tags has been added to have a much better control over the maximum number of bits that the GLCMul operation can have
A few more tests have been added.

Adding comments to the circuits.bn128

…initial number is positive, adding LessThan64Bits to check that number is less than 64 bits

RogerTaule and others added 7 commits October 11, 2023 13:48

Adding rootC as part of the transcript

a5f68f3

Adding tags to check that inputs are GL

4ab2109

Fixing BN128 circuit tests to work with tags

64530e0

Adding tests for edge cases of verifyEvaluations

46127f9

Adding some comments to the bn128 circuits

cf752ee

Commenting the bn1togl3 circuit

615d9fd

Merge pull request #50 from 0xPolygonHermez/feature/circuit-comments

f8922c4

Adding comments to the circuits.bn128

cla-bot bot added the cla-signed label Oct 12, 2023

RogerTaule force-pushed the feature/constRootTranscript branch 2 times, most recently from 4752368 to 255c5d8 Compare October 12, 2023 14:15

Adding tests for C12 and C18 on github actions

48800ca

RogerTaule force-pushed the feature/constRootTranscript branch from 255c5d8 to 48800ca Compare October 12, 2023 14:42

RogerTaule added 3 commits October 13, 2023 01:29

Adding inspect suggestion to glNorm

f5dc850

Calculating maxQuotientBits inside GLCMul, GLMul and GLNorm templates

879d5a3

Minor fix imports StarkVerifierBn128

421fd6d

RogerTaule force-pushed the feature/constRootTranscript branch from 9841209 to 421fd6d Compare October 13, 2023 09:45

RogerTaule added 2 commits October 13, 2023 15:33

Adding extra constraints to LessThanGoldilocks to make sure that the …

c3fac67

…initial number is positive, adding LessThan64Bits to check that number is less than 64 bits

Minor fix set Challenges

b6f11e4

RogerTaule merged commit 4204fd2 into develop Oct 16, 2023
4 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding constRoot to the transcript and tags #51

Adding constRoot to the transcript and tags #51

RogerTaule commented Oct 12, 2023 •

edited

Loading

Adding constRoot to the transcript and tags #51

Adding constRoot to the transcript and tags #51

Conversation

RogerTaule commented Oct 12, 2023 • edited Loading

RogerTaule commented Oct 12, 2023 •

edited

Loading