Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cargo-component to v0.7 #107

Closed
greenhat opened this issue Jan 26, 2024 · 2 comments · Fixed by #125
Closed

Update cargo-component to v0.7 #107

greenhat opened this issue Jan 26, 2024 · 2 comments · Fixed by #125
Assignees
@greenhat
Labels
testing
Milestone
Builder's Testnet

Comments

@greenhat
Copy link
Contributor

Following #106

The bindings generation approach was changed. See bytecodealliance/cargo-component#212 for details.
@greenhat greenhat self-assigned this Jan 26, 2024
@greenhat
Copy link
Contributor Author

I'm putting this issue aside for now. I found no_std component build issues - bytecodealliance/cargo-component#226 . I'll get back to this when I get a feedback.

@greenhat
Copy link
Contributor Author

greenhat commented Feb 6, 2024

I'm putting this issue aside for now. I found no_std component build issues - bytecodealliance/cargo-component#226 . I'll get back to this when I get a feedback.

The issue was that no_std was effectively ignored with one of the dependencies pulling in the stdlib allocator. See bytecodealliance/cargo-component#226 (comment) for details.

So with cargo-component v0.7 we have true no_std and have to deal with it. I'm putting this issue back on my radar.

@greenhat greenhat added this to the Builder's Testnet milestone Feb 7, 2024
@greenhat greenhat mentioned this issue Feb 8, 2024
Merged
@greenhat greenhat linked a pull request Feb 8, 2024 that will close this issue
Update cargo-component to v0.7.0, use wee_alloc in Wasm components and Miden SDK tests. #125
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greenhat greenhat

Labels
testing
Projects
None yet
Milestone
Builder's Testnet
1 participant
@greenhat