Update cargo-component to v0.7.0, use wee_alloc in Wasm components and Miden SDK tests.
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwalker
approved these changes
Feb 10, 2024
|
|
||
| #[panic_handler] | ||
| fn my_panic(_info: &core::panic::PanicInfo) -> ! { | ||
| loop {} |
There was a problem hiding this comment.
I think you end up with even better codegen if you use core::intrinsics::abort() here, though that comes with the need for #![feature(core_intrinsics)]
There was a problem hiding this comment.
Sure. I made #124 for this earlier and planned to make a separate PR for it. To keep PR sizes small and gauge the changes separately.
components and Miden SDK tests. The panic handler and global allocator is now set in the `lib.rs` file of each component crate. Before, the `cargo-component-bindings` was not built correctly for `no_std` and was linking the stdlib allocator. The Rust bindings for the WIT are now generated in the `src` directory of the component crate, instead of the `target/.../bindings` directory. The Wasm `bulk-memory` proposal is enabled via `RUSTFLAGS` so that `memcpy` function import is replaced with Wasm `memory.copy` op.
greenhat
force-pushed
the
greenhat/i107-cargo-comp-v0.7
branch
from
7bc8936 to
c46ca5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #107
This PR is stacked on top of #100 and should be merged after it
In this PR:
The panic handler and global allocator is now set in the
lib.rsfile of each component crate. Before, thecargo-component-bindingswas not built correctly forno_stdand was linking the stdlib allocator.The Rust bindings for the WIT are now generated in the
srcdirectory of the component crate, instead of thetarget/.../bindingsdirectory.The Wasm
bulk-memoryproposal is enabled viaRUSTFLAGSso thatmemcpyfunction import is replaced with Wasmmemory.copyop.