Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve miden-tx-prover error handling #1016

Closed
SantiagoPittella opened this issue Dec 12, 2024 · 2 comments
Closed

Improve miden-tx-prover error handling #1016

SantiagoPittella opened this issue Dec 12, 2024 · 2 comments
Assignees
Milestone

Comments

@SantiagoPittella
Copy link
Collaborator

What should be done?

As the error cases in the prover and proxy kept growing, using String as error type is no longer suitable. We should implement an error type, following the standards across miden's repos to facilitate the usage of the CLI.

How should it be done?

A new error enum should be in place, and we should use thiserror like in other miden's crates.

When is this task done?

The task is done when the functions and methods that uses String as error type are replaced with an error from the new enum.

Additional context

No response

@SantiagoPittella
Copy link
Collaborator Author

We might use this issue to improve a bit documentation and comments that are now outdated. Like: #1014 (comment)

@bobbinth
Copy link
Contributor

bobbinth commented Jan 2, 2025

Closed by #1038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants