Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add error for tx prover proxy #1038

Merged
merged 10 commits into from
Jan 2, 2025
Merged

feat: add error for tx prover proxy #1038

merged 10 commits into from
Jan 2, 2025

Conversation

SantiagoPittella
Copy link
Collaborator

closes #1016

@SantiagoPittella
feat: add error for tx prover proxy
5909f85 
chore: fix section headers
@SantiagoPittella SantiagoPittella added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Dec 26, 2024
bobbinth
bobbinth reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left some comments inline.

bin/tx-prover/src/error.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/utils.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/utils.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/proxy/mod.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/error.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/error.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/lib.rs Outdated Show resolved Hide resolved
bobbinth
bobbinth approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few comments inline - all of them a small nits.

bin/tx-prover/src/utils.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/proxy/worker.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/proxy/mod.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/error.rs Outdated Show resolved Hide resolved
bin/tx-prover/src/commands/proxy.rs Outdated Show resolved Hide resolved
@SantiagoPittella SantiagoPittella mentioned this pull request Jan 2, 2025
Open
bobbinth
bobbinth approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@bobbinth bobbinth merged commit 2072088 into next Jan 2, 2025
9 checks passed
@bobbinth bobbinth deleted the santiagopittella-miden-tx-prover-errors branch January 2, 2025 17:47
@bobbinth bobbinth mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippGackstatter PhilippGackstatter PhilippGackstatter left review comments

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SantiagoPittella @PhilippGackstatter @bobbinth