Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs]: Update
State
section #1029[Docs]: Update
State
section #1029Changes from 11 commits
6a784bb
958b3ec
60306bd
c3fe20d
d2a215e
3a4cf39
28d9a02
8155a2b
d3db130
9225e3d
1903f3d
0d4dd6b
735cef6
4c184bd
d37e712
9529ec2
1739bf8
a8f4c81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This picture is outdated: we don't actually have a separate notes MMR. Instead, we have the blockchain MMR where every leaf is a block header. Then, each block header contains a commitment to the notes created in that block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this diagram outdated? It states that nullifiers values are either 0/1 but they are the block number in which the note was consumed.
It also mentions the nullifier tree is a tiered sparse merkle tree, though right now it is just an SMT. Not sure right now if the plan is for it to be a tiered SMT in the future to support dropping older epochs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of this section but I think it should be a part of a bigger section the describes how different users work with the state. Specifically, we could come up with different types of state:
Would be good to describe how these work and what are the tradeoffs between them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.