feat: make MAX_DECIMALS public #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
approved these changes
Jan 14, 2025
| /// The maximum value for the `max_supply` field. | ||
| pub const MAX_MAX_SUPPLY: u64 = (1 << 63) - 1; | ||
|
|
||
| /// The maximum number of decimals supported by the component. |
There was a problem hiding this comment.
Is this enforced at the protocol-level? Because if so we could write something like this (same for above):
Suggested change
| /// The maximum number of decimals supported by the component. | |
| /// The maximum number of decimals supported by faucets in the protocol. |
There was a problem hiding this comment.
MAX_DECIMALS is not enforced at the protocol level.
|
I'm not really happy with the result here. Maybe having these constants in the |
bobbinth
reviewed
Jan 15, 2025
SantiagoPittella
changed the title
SantiagoPittella
force-pushed
the
santiagopittella-make-max-decimals-public
branch
from
8488e8a to
1c4b4c5
Compare
SantiagoPittella
deleted the
santiagopittella-make-max-decimals-public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use this values in the miden-client repo to avoid repetition. 0xPolygonMiden/miden-client#476