Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel::account::get_map_item #1073

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

PhilippGackstatter
Copy link
Contributor

Refactors the get_account_map_item kernel procedure to call an underlying kernel::account::get_map_item which is responsible for checking the slot type and retrieving the actual data.

Removes the extra decorator operations which I believe can now be removed due to 0xPolygonMiden/miden-vm#1122 being fixed.

Fixes some outdated MASM docs.

This implements #768 except for any event refactoring.

@PhilippGackstatter PhilippGackstatter added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jan 16, 2025
@PhilippGackstatter PhilippGackstatter marked this pull request as ready for review January 16, 2025 16:41
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@PhilippGackstatter PhilippGackstatter merged commit 3326306 into next Jan 17, 2025
11 checks passed
@PhilippGackstatter PhilippGackstatter deleted the pgackst-remove-decorator-ops branch January 17, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants