-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Onchain notes tutorial #604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good! I think that since the init
command will be introduced in the upcoming release of miden-client
, we can update the getting-started tutorials in order to do the setup with:
cargo install ...
miden-client init
(and overriding the necessary configurations)
I tried following the getting-started steps but got stuck when trying to import the first input note: FungibleAssetInvalidWord([7023146166627099489, 7078034031914609772, 7596728195356390241, 8390045827181995364]) I'm guessing it's because the deployed faucet at Edit: upon second thought, you'll probably need a release of the client before deploying the faucet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think with the miden-client init
inclusion it should be good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the updated version. I will do another review when we have our remote nodes running. Then I can test the tutorial against a real node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, we only need to wait for the new faucet address before we can merge
…xPolygonMiden/miden-base into igamigo-onchain-notes-tutorial
@Dominik1999 @bobbinth @mFragaBA @igamigo I'll check this again when the faucet works and I can update the preliminary step too. Let me know. A few language tips: avoid the future tense and the passive tense in favor of present simple. Avoid the word "utilize", just say "use". Use US English. Thank you :) |
…nto igamigo-onchain-notes-tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the language, added some clarifications, tested the flow. 100% happy everything is working now.
Ok, then we rebase and merge to |
No description provided.