Fix docs build again #632
Closed
Fix docs build again #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we close this PR? |
|
No @bobbinth you can approve it ... it's just a small name change, we reverted it because the build broke but that was for another reason.. |
|
Unless, of course, it's been done elsewhere, in which case, yes, close. @Dominik1999 may know better |
|
We can merge this of course, but as far as I can tell, this PR has no changes. Or am I missing something? |
It had one change which was then reverted. It would be good to get this in if it's not yet in. However, it's another PR with a ton of merge conflicts I can't deal with because they're files outside of my remit. So let's close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.