Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Ord and PartialOrd for NoteTag #656

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

tomyrd
Copy link
Collaborator

@tomyrd tomyrd commented May 2, 2024

Remake of PR #644 as it was reverted.

Add Ord and PartialOrd derives to NoteTag so that we can use BTreeSetto check for duplicates efficiently.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit f23a90d into next May 2, 2024
9 checks passed
@bobbinth bobbinth deleted the tomyrd-add-ord-to-note-tag branch May 2, 2024 19:15
bobbinth pushed a commit that referenced this pull request May 13, 2024
bobbinth pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants