Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conversion from Nullifier for InputNoteCommitment #774

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

polydez
Copy link
Contributor

@polydez polydez commented Jun 28, 2024

This is needed for testing simplification (it's so hard to construct new authenticated note just for testing purposes). With this change we can simply convert nullifier to authenticated input note commitment.

Related to 0xPolygonMiden/miden-node#390

…rn reference to note header instead of copy
@polydez polydez requested a review from bobbinth June 28, 2024 15:54
@polydez polydez force-pushed the polydez-commitment-from-nullifier branch from 617eadd to 1a420cf Compare June 28, 2024 19:15
@polydez polydez requested a review from bobbinth June 28, 2024 19:15
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a couple of very minor comments inline. Once these are addressed, we can merge.

objects/src/transaction/proven_tx.rs Outdated Show resolved Hide resolved
objects/src/transaction/proven_tx.rs Outdated Show resolved Hide resolved
@bobbinth bobbinth merged commit 861837b into next Jun 28, 2024
12 checks passed
@bobbinth bobbinth deleted the polydez-commitment-from-nullifier branch June 28, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants