Implemented OutputNote::hash
#782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Jul 2, 2024
objects/src/notes/header.rs
Outdated
| /// | ||
| /// This value is used primarily for authenticating notes consumed when they are consumed | ||
| /// in a transaction. | ||
| pub fn note_hash(id: NoteId, metadata: &NoteMetadata) -> Digest { |
There was a problem hiding this comment.
nit: I would rename this into build_note_hash() or compute_note_hash().
objects/src/transaction/outputs.rs
Outdated
Comment on lines
212
to
214
| /// This value is used primarily for authenticating notes consumed when they are consumed | ||
| /// in a transaction. | ||
| pub fn hash(&self) -> Digest { |
There was a problem hiding this comment.
I would probably get rid of this part of the comment since here we are in an output note.
bobbinth
pushed a commit
that referenced
this pull request
Jul 4, 2024
* feat: implement `OutputNote::hash` * fix: review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this method in order to easily calculate hash for output notes. Related to 0xPolygonMiden/miden-node#396