Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking PR for v0.5 release #787

Merged
merged 51 commits into from
Aug 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
a78a6d8
chore: update crate versions to 0.5.0
bobbinth Jul 4, 2024
da10ea7
fix: remove useless inclusion proof from `NoteBuilder` (#792)
polydez Jul 10, 2024
5482077
Update names used for input/output notes (#791)
Fumuran Jul 10, 2024
be25e83
feat: Change `TransactionArgs` to use `AdviceInputs` (#793)
tomyrd Jul 12, 2024
9de838a
chore: update changelog
bobbinth Jul 12, 2024
19df86c
refactor: make memory setters consistent (#795)
Fumuran Jul 13, 2024
dd5b7b9
Allow increasing an account's nonce without changing its state (#796)
Fumuran Jul 18, 2024
911ffbe
test: Add test for executing transactions with new accounts (#801)
igamigo Jul 22, 2024
6abf53e
chore: add warning for `CHANGELOG.md` (#799)
phklive Jul 22, 2024
51e0656
chore: refresh Cargo.lock
bobbinth Jul 22, 2024
2a34de3
fix: typo in changelog
bobbinth Jul 22, 2024
8af3e34
chore: switch to rust-toolchain.toml
bobbinth Jul 22, 2024
5cb5047
feat: merge account updates details (#797)
Mirko-von-Leipzig Jul 24, 2024
56516f3
chore: add labeled and unlabeled triggers to changlog check task
bobbinth Jul 29, 2024
a942c54
docs: fix typos (#805)
omahs Jul 29, 2024
194267b
test: Remove test subdir in favor of inline mod (#809)
igamigo Jul 30, 2024
b2b6621
feat: `AccountCode` refactor from MerkleTree to sequential hash for o…
phklive Jul 30, 2024
5d61865
Refactored `NoteOrigin` and `NoteInclusionProof` structs (#810)
polydez Aug 2, 2024
493e193
Made `node_index_in_block` method return `u32` (#814)
polydez Aug 2, 2024
781ab43
feat: Add `NoteExecutionHint`; rename previously existing enum (#812)
igamigo Aug 5, 2024
3e77745
Make `build_swap_tag()` public (#817)
Fumuran Aug 5, 2024
27e0e7a
feat: add after_block_num to NoteFile::NoteDetails
SantiagoPittella Aug 9, 2024
b33d186
doc: Update changelog
SantiagoPittella Aug 9, 2024
c312e41
add comment about the new field
SantiagoPittella Aug 9, 2024
72ea4d8
Update comment
SantiagoPittella Aug 9, 2024
52522d3
Merge pull request #823 from 0xPolygonMiden/add-field-to-note-details
SantiagoPittella Aug 9, 2024
77f0f74
Implement `send_note` for basic wallet (#808)
Fumuran Aug 9, 2024
19c750f
feat: implement serialization and `Eq` for `TransactionScript` (#824)
tomyrd Aug 9, 2024
126d276
feat: Encode `NoteExecutionHint` into `NoteMetadata` (#816)
igamigo Aug 10, 2024
30ef0b2
refactor: fix typo in create_note, remove excess proc from account co…
Fumuran Aug 10, 2024
e89e3ea
chore: update miden-vm dependencies to v0.10 in Cargo.toml files
bobbinth Aug 11, 2024
017d4be
feat: add conversion for `NoteExecutionHint` (#827)
igamigo Aug 12, 2024
4ff85b7
Refactored delta's vault and storage to use maps (#822)
polydez Aug 22, 2024
3f7a538
refactor: update miden-objects to miden-vm v0.10
bobbinth Aug 11, 2024
267e907
Refactored delta's vault and storage to use maps (#822)
polydez Aug 22, 2024
9631e8a
test: Add more high-level methods to `MockChain` (#807)
igamigo Aug 22, 2024
ed3abea
Merge branch 'next' into bobbin-miden-vm-migration
bobbinth Aug 23, 2024
fd89bc3
doc: document TransactionMastStore
bobbinth Aug 23, 2024
280f590
merge migration to `miden-vm` v0.10
bobbinth Aug 23, 2024
b02bca8
ci: workflow improvements (#818)
Mirko-von-Leipzig Aug 23, 2024
fd53a65
chore: fix typos
bobbinth Aug 23, 2024
217c8bc
test: Consume multiple notes (#837)
bobbinth Aug 23, 2024
4c795a8
refactor: reenable bench-tx (#840)
Fumuran Aug 23, 2024
d259ebe
fix: account code serialization
bobbinth Aug 23, 2024
edaa392
fix: conditionally import dependency and pass RNG as param (#841)
igamigo Aug 26, 2024
707f920
refactor: change max number of account procedures back to 256 (#839)
bobbinth Aug 26, 2024
436f951
chore: improve comment formatting
bobbinth Aug 27, 2024
816cf77
chore: move local crate dependencies to the workspace
bobbinth Aug 27, 2024
b7879e8
Update index.md
gobsponge Jul 26, 2024
94ea904
Merge branch 'main' into next
bobbinth Aug 27, 2024
1af2cfa
chore: update changelog
bobbinth Aug 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

name: build

# Limits workflow concurrency to only the latest commit in the PR.
concurrency:
group: "${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}"
cancel-in-progress: true

on:
push:
branches: [main, next]
Expand All @@ -10,30 +15,32 @@ on:

jobs:
async:
name: Build using `async` feature
name: build using async feature
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
toolchain: [stable, nightly]
steps:
- uses: actions/checkout@main
- name: Build using `async` feature
- uses: Swatinem/rust-cache@v2
with:
# Only update the cache on push onto the next branch. This strikes a nice balance between
# cache hits and cache evictions (github has a 10GB cache limit).
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/next' }}
- name: build
run: |
rustup update --no-self-update ${{ matrix.toolchain }}
rustup update --no-self-update
make build-async

no-std:
name: Build for no-std
name: build for no-std
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
toolchain: [stable, nightly]
steps:
- uses: actions/checkout@main
- name: Build for no-std
- uses: Swatinem/rust-cache@v2
with:
# Only update the cache on push onto the next branch. This strikes a nice balance between
# cache hits and cache evictions (github has a 10GB cache limit).
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/next' }}
- name: build
run: |
rustup update --no-self-update ${{ matrix.toolchain }}
rustup update --no-self-update
rustup target add wasm32-unknown-unknown
make build-no-std
23 changes: 23 additions & 0 deletions .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Runs changelog related jobs.
# CI job heavily inspired by: https://github.com/tarides/changelog-check-action

name: changelog

on:
pull_request:
types: [opened, reopened, synchronize, labeled, unlabeled]

jobs:
changelog:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@main
with:
fetch-depth: 0
- name: Check for changes in changelog
env:
BASE_REF: ${{ github.event.pull_request.base.ref }}
NO_CHANGELOG_LABEL: ${{ contains(github.event.pull_request.labels.*.name, 'no changelog') }}
run: ./scripts/check-changelog.sh "${{ inputs.changelog }}"
shell: bash
58 changes: 39 additions & 19 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,52 +2,72 @@

name: lint

# Limits workflow concurrency to only the latest commit in the PR.
concurrency:
group: "${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}"
cancel-in-progress: true

on:
push:
branches: [main, next]
pull_request:
types: [opened, reopened, synchronize]

jobs:
version:
name: check rust version consistency
clippy:
name: clippy
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
- uses: Swatinem/rust-cache@v2
with:
profile: minimal
override: true
- name: check rust versions
run: ./scripts/check-rust-version.sh
# Only update the cache on push onto the next branch. This strikes a nice balance between
# cache hits and cache evictions (github has a 10GB cache limit).
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/next' }}
- name: Clippy
run: |
rustup update --no-self-update
rustup component add clippy
make clippy

rustfmt:
name: rustfmt check nightly on ubuntu-latest
name: rustfmt
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
- uses: Swatinem/rust-cache@v2
with:
# Only update the cache on push onto the next branch. This strikes a nice balance between
# cache hits and cache evictions (github has a 10GB cache limit).
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/next' }}
- name: Rustfmt
run: |
rustup update --no-self-update nightly
rustup +nightly component add rustfmt
make format-check

clippy:
name: clippy nightly on ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
- name: Clippy
run: |
rustup update --no-self-update nightly
rustup +nightly component add clippy
make clippy

doc:
name: doc stable on ubuntu-latest
name: doc
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
- uses: Swatinem/rust-cache@v2
with:
# Only update the cache on push onto the next branch. This strikes a nice balance between
# cache hits and cache evictions (github has a 10GB cache limit).
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/next' }}
- name: Build docs
run: |
rustup update --no-self-update
make doc

version:
name: check rust version consistency
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
with:
profile: minimal
override: true
- name: check rust versions
run: ./scripts/check-rust-version.sh
31 changes: 18 additions & 13 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

name: test

# Limits workflow concurrency to only the latest commit in the PR.
concurrency:
group: "${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}"
cancel-in-progress: true

on:
push:
branches: [main, next]
Expand All @@ -10,19 +15,19 @@ on:

jobs:
test:
name: test ${{matrix.toolchain}} on ${{matrix.os}} with ${{matrix.args}}
runs-on: ${{matrix.os}}-latest
strategy:
fail-fast: false
matrix:
toolchain: [stable, nightly]
os: [ubuntu]
args: [default, prove]
timeout-minutes: 30
name: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
- uses: taiki-e/install-action@nextest
- name: Perform tests
run: |
rustup update --no-self-update ${{matrix.toolchain}}
make test-${{matrix.args}}
- uses: Swatinem/rust-cache@v2
with:
save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/next' }}
- name: Install rust
run: rustup update --no-self-update
- name: Build tests
run: make test-build
- name: test-default
run: make test-default
- name: test-prove
run: make test-prove
34 changes: 31 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,33 @@
# Changelog

## 0.5.0 (2024-08-27)

### Features

- [BREAKING] Increase of nonce does not require changes in account state any more (#796).
- Changed `AccountCode` procedures from merkle tree to sequential hash + added storage_offset support (#763).
- Implemented merging of account deltas (#797).
- Implemented `create_note` and `move_asset_into_note` basic wallet procedures (#808).
- Made `miden_lib::notes::build_swap_tag()` function public (#817).
- [BREAKING] Changed the `NoteFile::NoteDetails` type to struct and added a `after_block_num` field (#823).

### Changes

- Renamed "consumed" and "created" notes into "input" and "output" respectively (#791).
- [BREAKING] Renamed `NoteType::OffChain` into `NoteType::Private`.
- [BREAKING] Renamed public accessors of the `Block` struct to match the updated fields (#791).
- [BREAKING] Changed the `TransactionArgs` to use `AdviceInputs` (#793).
- Setters in `memory` module don't drop the setting `Word` anymore (#795).
- Added `CHANGELOG.md` warning message on CI (#799).
- Added high-level methods for `MockChain` and related structures (#807).
- [BREAKING] Renamed `NoteExecutionHint` to `NoteExecutionMode` and added new `NoteExecutionHint` to `NoteMetadata` (#812, #816).
- [BREAKING] Changed the interface of the `miden::tx::add_asset_to_note` (#808).
- [BREAKING] Refactored and simplified `NoteOrigin` and `NoteInclusionProof` structs (#810, #814).
- [BREAKING] Refactored account storage and vault deltas (#822).
- Added serialization and equality comparison for `TransactionScript` (#824).
- [BREAKING] Migrated to Miden VM v0.10 (#826).
- Added conversions for `NoteExecutionHint` (#827).

## 0.4.0 (2024-07-03)

### Features
Expand Down Expand Up @@ -34,9 +62,9 @@

## 0.3.1 (2024-06-12)

* Replaced `cargo-make` with just `make` for running tasks (#696).
* Made `DataStore` conditionally async using `winter-maybe-async` (#725)
* Fixed `StorageMap`s implementation and included into apply_delta (#745)
- Replaced `cargo-make` with just `make` for running tasks (#696).
- Made `DataStore` conditionally async using `winter-maybe-async` (#725)
- Fixed `StorageMap`s implementation and included into apply_delta (#745)

## 0.3.0 (2024-05-14)

Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ To make sure all commits adhere to our programming standards we use [pre-commit]
2. Commit messages and code style follow conventions.
3. Tests added for new functionality.
4. Documentation/comments updated for all changes according to our documentation convention.
5. Rustfmt, Clippy and Rustdoc linting passed (Will be ran automatically by pre-commit).
5. Rustfmt, Clippy and Rustdoc linting passed (Will be run automatically by pre-commit).
6. New branch rebased from `next`.

 
Expand Down
Loading
Loading