Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make memory setters consistent #795

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Make memory setters consistent #795

merged 3 commits into from
Jul 13, 2024

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Jul 12, 2024

This small PR changes the setters in the memory module to make them more consistent: Word setters don't drop the setting Word anymore.

Related issue: #773

@Fumuran Fumuran requested a review from bobbinth July 12, 2024 13:09
@bobbinth bobbinth force-pushed the andrew-make-memory-setters-consistent branch from e2bf68e to b52544c Compare July 12, 2024 23:47
bobbinth
bobbinth approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I reverted the change to one of the procedures and also moved the changelog update to the appropriate section.

@bobbinth bobbinth merged commit 19df86c into next Jul 13, 2024
12 checks passed
@bobbinth bobbinth deleted the andrew-make-memory-setters-consistent branch July 13, 2024 00:02
@bobbinth bobbinth mentioned this pull request Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fumuran @bobbinth