-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic kernel procedure invocation #803
Conversation
I am putting forward a proposal to put on hold this task until the Miden VM 0.10 is released. It is extremely complicated to make this feature work using the "pre-refactoring" version of the assembler. To make it work it's needed to put the hash of the desired procedure to the The other options is to try to change the dependencies of the Currently the core functionality for that feature is already implemented, so it shouldn't take too long to finish it after new version of the VM is released. @bobbinth what do you think? |
2254f85
to
977ec96
Compare
6642058
to
814e470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good! Not a full review yet, but I left some comments inline.
Also, I'm curious how this affects cycle counts for our transaction benchmarks.
814e470
to
164c946
Compare
90237a8
to
2ecedfb
Compare
2ecedfb
to
eabf4da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I've added some more comments inline.
15fe435
to
64723f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left some more comments inline. The main one is about checking kernel procedure bounds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few small comments inline. Once these are addressed, we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Thank you!
This PR reworks the way
syscall
procedures being executed: instead of usingsyscall
for each procedure, now we load the offset of the desired procedure to the stack and then executesyscall.exec_kernel_proc
. More details can be found in the corresponding issue: #701.TODO: