-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Transaction kernel error constant generation #906
feat: Transaction kernel error constant generation #906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Great work!
I suggested some changes inline, but the main thing is that we should also check the miden
and note_scripts
folders for errors to include them in the generated list.
2afa7ff
to
a22032e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you! I left just two small comments inline. Once these are addressed, we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
a22032e
to
bc240e0
Compare
Generates the transaction kernel error constants from the masm files with a
build.rs
file.Also reworks the error names aligned with #712 and supersedes that PR.
I did not generally add a context to the error messages like "transaction prologue: account nonce must be ..." but rather tried to weave the context into the error message to make its origin clear.
Some unused error constants in the prologue were removed.
Closes #671
See that issue's comments for details.