Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add conversions for NoteRecordDetails #392

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

tomyrd
Copy link
Collaborator

@tomyrd tomyrd commented Jun 24, 2024

Addresses this comment

This PR looks to refactor the creation of NoteRecordDetails from Note and NoteDetails by impementing From conversions.

@tomyrd tomyrd force-pushed the tomyrd-import-notefile branch 4 times, most recently from bbfe6ad to 51d2a8b Compare June 25, 2024 15:46
@tomyrd tomyrd force-pushed the tomyrd-note-conversions branch from 5fe5807 to d058ba7 Compare June 26, 2024 21:37
Base automatically changed from tomyrd-import-notefile to next June 28, 2024 19:45
@tomyrd tomyrd force-pushed the tomyrd-note-conversions branch from d058ba7 to 14f63dc Compare July 5, 2024 17:11
@tomyrd tomyrd marked this pull request as ready for review July 5, 2024 17:13
@tomyrd tomyrd force-pushed the tomyrd-note-conversions branch from be1a5f2 to ef77854 Compare July 8, 2024 17:47
Copy link
Contributor

@mFragaBA mFragaBA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mFragaBA mFragaBA merged commit f99794a into next Jul 8, 2024
11 checks passed
@mFragaBA mFragaBA deleted the tomyrd-note-conversions branch July 8, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants