testfix: flaky tests fix attempt #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mFragaBA
force-pushed
the
mFragaBA-flaky-tests-fix-attempt
branch
from
a8142e5 to
045ed8b
Compare
Closed
mFragaBA
force-pushed
the
mFragaBA-flaky-tests-fix-attempt
branch
from
ad3c613 to
617c6cd
Compare
mFragaBA
force-pushed
the
mFragaBA-flaky-tests-fix-attempt
branch
from
617c6cd to
8e21f03
Compare
In some tests we did some assertions by doing `client.get_input_notes(filter).unwrap()` and checking the length of it. While in most cases that is enough, it will sporadically become an error if the node running the integration test has notes whose tag was built with another account's id that also has the same prefix (and hence the same tag as the ones created for the actually desired account). In order to mitigate it, we do a filter by account_id to ensure the note we want is there (there might be others, we won't care too much). In the case of swap tests, I also used `get_consumable_notes` since in that situation we wanted to consume the notes anyways.
mFragaBA
force-pushed
the
mFragaBA-flaky-tests-fix-attempt
branch
from
8e21f03 to
82b30da
Compare
igamigo
approved these changes
Jul 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #391. (The PR is already reviewable but I think this will be included in the following release).
In some tests we do some assertions with
client.get_input_notes(filter).unwrap()and checking the length of it. While in most cases that is enough, it will sporadically fail If the node running the integration test has public notes belonging to another account with the same account id prefix (the one used to create the note tag). In order to mitigate it, we do a filter by account_id to ensure the note we want is there (there might be others, we won't care too much). In the case of swap tests, I also usedget_consumable_notessince in that situation we wanted to consume the notes anyways.