feat: import committed notes from older blocks that current #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igamigo
reviewed
Aug 9, 2024
SantiagoPittella
force-pushed
the
import-past-commited-notes
branch
from
cb04529 to
d6fc884
Compare
igamigo
reviewed
Aug 13, 2024
SantiagoPittella
force-pushed
the
import-past-commited-notes
branch
from
f2db2f1 to
baa789e
Compare
tomyrd
approved these changes
Aug 15, 2024
SantiagoPittella
force-pushed
the
import-past-commited-notes
branch
from
a27e5be to
ceb8960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #405
### Do not merge until 0xPolygonMiden/miden-base#823 is merged.This PR adds support for committed notes from "the past" (in the client's perspective).
TO DOs:
after_block_numfield inNoteFile::NoteDetailsas explained here.after_block_numfield toNoteFile::NoteDetailsmiden-base#823