removed analytics param; added disableAnalytics bool param

0xsequence · Jan 31, 2024 · 533d276 · 533d276
1 parent f0fbf30
commit 533d276
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/packages/kit/src/components/KitProvider/ConnectWalletContent/index.tsx b/packages/kit/src/components/KitProvider/ConnectWalletContent/index.tsx
@@ -6,7 +6,6 @@ import{ EMAIL_CONNECTOR_LOCAL_STORAGE_KEY } from '@0xsequence/kit-connectors'
 import { ExtendedWalletList } from './ExtendedWalletList'
 import { Banner } from './Banner'
 
-import { useAnalyticsContext } from '../../../contexts'
 import { KitConfig } from '../../index'
 import { defaultSignInOptions } from '../../../constants'
 import { isEmailValid } from '../../../utils'

diff --git a/packages/kit/src/components/KitProvider/index.tsx b/packages/kit/src/components/KitProvider/index.tsx
@@ -51,7 +51,7 @@ export interface EthAuthSettings {
 }
 
 export interface KitConfig {
-  analytics?: SequenceClient["analytics"]
+  disableAnalytics?: boolean,
   projectAccessKey: string,
   defaultTheme?: Theme,
   position?: ModalPosition,
@@ -64,7 +64,7 @@ export interface KitConfig {
     useMock?: boolean
   },
   displayedAssets?: DisplayedAsset[],
-  ethAuth?: EthAuthSettings
+  ethAuth?: EthAuthSettings,
 }
 
 export type KitConnectProviderProps = {
@@ -81,7 +81,7 @@ export const KitProvider = (props: KitConnectProviderProps) => {
     position = 'center',
     displayedAssets: displayedAssetsSetting = [],
     ethAuth = {} as EthAuthSettings,
-    analytics: analyticsParams,
+    disableAnalytics = false,
   } = config
 
   const defaultAppName = signIn.projectName || 'app'
@@ -96,11 +96,7 @@ export const KitProvider = (props: KitConnectProviderProps) => {
   const [analytics, setAnalytics] = useState<SequenceClient["analytics"]>()
   const { address, isConnected } = useAccount()
 
-  const setupAnalytics = (projectAccessKey: string, analyticsObj?: SequenceClient["analytics"]) => {
-    if (analyticsObj) {
-      setAnalytics(analyticsObj)
-      return
-    }
+  const setupAnalytics = (projectAccessKey: string) => {
     const s = sequence.initWallet(projectAccessKey)
     const sequenceAnalytics = s.client.analytics
     setAnalytics(sequenceAnalytics)
@@ -121,9 +117,11 @@ export const KitProvider = (props: KitConnectProviderProps) => {
   }
 
   useEffect(() => {
-    setupAnalytics(projectAccessKey, analyticsParams)
+    if (!disableAnalytics) {
+      setupAnalytics(projectAccessKey)
+    }
     localStorage.setItem(LocalStorageKey.ProjectAccessKey, projectAccessKey)
-  }, [projectAccessKey, analyticsParams])
+  }, [projectAccessKey])
 
   useEffect(() => {
     if (theme !== defaultTheme) {