Skip to content

Commit

Permalink
Issue 3555 - Remove audit-ci from dependencies (#6056)
Browse files Browse the repository at this point in the history
Description: We use npx for audit-ci runs. Hence we don't need the
package installed at all.
Remove audit-ci from package.json and a new generate package-lock.json.

Related: #3555

Reviewed by: @vashirov (Thanks!)
  • Loading branch information
droideck committed Jan 29, 2024
1 parent 651d44f commit 2bd4534
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 276 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ jobs:
uses: actions/checkout@v3

- name: Run NPM Audit CI
run: cd $GITHUB_WORKSPACE/src/cockpit/389-console && npx audit-ci --config audit-ci.json
run: cd $GITHUB_WORKSPACE/src/cockpit/389-console && npx --yes audit-ci --config audit-ci.json
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
description: Specify tag to generate a tarball
required: true
skip-audit-ci:
description: Skip npm audit-ci
description: Skip npx --yes audit-ci
type: boolean
default: false

Expand Down
2 changes: 1 addition & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -2103,7 +2103,7 @@ $(NODE_MODULES_TEST):
cd src/cockpit/389-console; npm install

$(WEBPACK_TEST): $(NODE_MODULES_TEST)
cd src/cockpit/389-console; npx audit-ci; ./build.js
cd src/cockpit/389-console; npx --yes audit-ci; ./build.js

389-console: $(WEBPACK_TEST)

Expand Down
2 changes: 1 addition & 1 deletion rpm.mk
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ ifeq ($(COCKPIT_ON), 1)
npm ci > /dev/null
ifndef SKIP_AUDIT_CI
cd src/cockpit/389-console; \
npx audit-ci
npx --yes audit-ci
endif
endif

Expand Down
Loading

0 comments on commit 2bd4534

Please sign in to comment.