Skip to content

Commit

Permalink
Issue 6485 - Fix double free in USN cleanup task
Browse files Browse the repository at this point in the history
Description:

ASAN report shows double free of bind dn in the USN cleanup task data. The bind
dn was passed as a reference so it should never have to be freed by the cleanup
task.

Relates: #6485

Reviewed by: ?
  • Loading branch information
mreynolds389 committed Jan 8, 2025
1 parent b8e442b commit a90be9f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions ldap/servers/plugins/usn/usn_cleanup.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,6 @@ usn_cleanup_task_destructor(Slapi_Task *task)
if (mydata) {
slapi_ch_free_string(&mydata->suffix);
slapi_ch_free_string(&mydata->maxusn_to_delete);
slapi_ch_free_string(&mydata->bind_dn);
/* Need to cast to avoid a compiler warning */
slapi_ch_free((void **)&mydata);
}
}
Expand Down

0 comments on commit a90be9f

Please sign in to comment.